Add markers before and after the body to be able to remove rootless apps #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn’t seem breaking to me. If used with current ember-cli-fastboot the content will be properly cleaned up (just the boundaries will remain). What am I missing? |
|
You didn't miss anything. I just wasn't sure if generating different html, even if it should be irrelevant could be considered breaking. I do not know why tests are not running tho. |
|
There was a fairly severe TravisCI outage (still recovering AFAICT). I tried to restart the build... |
|
Ready to merge on my end. We could release as a minor version instead of a patch to be safe of any unintended consecuences? |
rwjblue
approved these changes
Jan 17, 2018
|
I'll try to get this published in the AM, unless @kratiahuja or others get to it first... |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rwjblue @kratiahuja Would you consider this breaking?
It must be released along with a new version of ember-cli-fastboot that knows how to remove DOM elements between those new two markers.