Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump ember-cli-babel from 6.7.1 to 7.26.10 #75

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

herzzanu
Copy link
Contributor

Solves #74

@herzzanu
Copy link
Contributor Author

@jasonmit @buschtoens Could you please have a look at this? 🙏 It might help a lot of people trying to upgrade to the latest Ember version.

@herzzanu
Copy link
Contributor Author

Any luck we can get this one merged? 🙏

@buschtoens
Copy link
Member

Sorry that this was left hanging so long. I unfortunatel didn't have a lot of time to spend on open source the past months.

I've never used @ember-intl/cp-validations myself, so I'm not really familiar with this project.

  • Do you think there's anything in particular I should pay attention to?
  • Looking at the changelog for ember-cli-babel@7.0.0 I think this should be a major release. Do you agree?

@buschtoens buschtoens merged commit 33131c4 into ember-intl:master Jan 20, 2022
@buschtoens
Copy link
Member

buschtoens commented Jan 20, 2022

@herzzanu This project is somewhat irrecoverably out-of-date. I opted for regenerating it from scratch and copying over and modernizing the few actual source files: #82

Unfortunately, as you're most likely already aware, issues like qonto/ember-cp-validations#3 or usage of the Ember global in ember-cp-validations & ember-validators are blocking issues.

I'm circumventing these for local development and CI via patch-package. This will not work in production use. Users will have to ensure themselves that compatible dependency versions are used.

I would appreciate, if you could publish @qonto/ember-cp-validations to npm and also take a look at my PR #82. There are still some more compatibility issues with ember-cp-validations, that are not yet in the @qonto repo, and there are issues with ember-validators.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants