Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add CSS styling for tables #192

Closed
IgnaceMaes opened this issue Jun 29, 2024 · 4 comments · Fixed by #199
Closed

Add CSS styling for tables #192

IgnaceMaes opened this issue Jun 29, 2024 · 4 comments · Fixed by #199
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@IgnaceMaes
Copy link
Member

Currently tables are unstyled in the guides. Some CSS should be written for the table element so it looks nicer.

image
@IgnaceMaes IgnaceMaes added enhancement New feature or request good first issue Good for newcomers labels Jun 29, 2024
@Ziphozenkosimthombe
Copy link

can I take that?

@IgnaceMaes
Copy link
Member Author

Feel free to give it a go!

Some extra details:

  • The styleguide should be used for color and spacing variables: https://ember-styleguide.netlify.app/concepts/colors/
  • An example of a table should be added to a markdown file in the test app so this can be revieed.
  • There is no design ready to follow. I think it would be nice to make the table full width. Try to make it fit in with the rest of the page.

@Ziphozenkosimthombe
Copy link

if I ask the table I should add it to the test-app folder inside the readme file? can you please give me more guidance on that.

@ArunPragadeeswar007
Copy link
Contributor

@IgnaceMaes please review this PR

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants