Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix : #192 Added styles for table element #198

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

ArunPragadeeswar007
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for guidemaker-ember-template ready!

Name Link
🔨 Latest commit 02428ec
🔍 Latest deploy log https://app.netlify.com/sites/guidemaker-ember-template/deploys/6683b6582111940008de26bc
😎 Deploy Preview https://deploy-preview-198--guidemaker-ember-template.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@IgnaceMaes IgnaceMaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🎉

Some small remarks.

guidemaker-ember-template/src/styles/addon.css Outdated Show resolved Hide resolved
test-app/guides/release/examples/index.md Show resolved Hide resolved
Co-authored-by: Ignace Maes <ignacemaes100@msn.com>
@ArunPragadeeswar007
Copy link
Contributor Author

@IgnaceMaes Please check now

@IgnaceMaes IgnaceMaes added the enhancement New feature or request label Jul 2, 2024
Copy link
Member

@IgnaceMaes IgnaceMaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for the contribution! 🔥

@ArunPragadeeswar007
Copy link
Contributor Author

Pipeline Failed anything need to do in my end @IgnaceMaes ?

@IgnaceMaes
Copy link
Member

The Percy changes were expected, and now approved so it's green.

The Ember Release test is labeled as Allowed to fail so it's fine.

@IgnaceMaes IgnaceMaes merged commit 13434f1 into ember-learn:main Jul 2, 2024
17 of 18 checks passed
@github-actions github-actions bot mentioned this pull request Jul 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants