Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Transform chapter-links to glimmer component #203

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

kennstenicht
Copy link
Contributor

For better readability, I have only formatted the the code in the first commit. I would recommend to ignore whitespaces.

Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for guidemaker-ember-template ready!

Name Link
🔨 Latest commit a6dbed1
🔍 Latest deploy log https://app.netlify.com/sites/guidemaker-ember-template/deploys/66a0cfd4f97c7c0008028b0d
😎 Deploy Preview https://deploy-preview-203--guidemaker-ember-template.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MinThaMie MinThaMie requested review from IgnaceMaes and mansona July 23, 2024 07:17
@mansona
Copy link
Member

mansona commented Jul 24, 2024

I've merged your other PR so I guess this one needs to be rebased to continue?

@kennstenicht kennstenicht force-pushed the refactor-chapter-links branch from 4bb7dee to a6dbed1 Compare July 24, 2024 09:56
@kennstenicht
Copy link
Contributor Author

@mansona I have rebased the branch.

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mansona mansona added the enhancement New feature or request label Jul 24, 2024
@mansona mansona merged commit 93209cb into ember-learn:main Jul 24, 2024
15 of 17 checks passed
@github-actions github-actions bot mentioned this pull request Jul 24, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants