Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revising the Octane Upgrade Guide #796

Merged
merged 8 commits into from
May 25, 2019
Merged

Revising the Octane Upgrade Guide #796

merged 8 commits into from
May 25, 2019

Conversation

jenweber
Copy link
Contributor

@jenweber jenweber commented May 20, 2019

If you're someone with push access to my PR, please feel free to edit directly whenever possible by adding commits rather than comments. It's much appreciated!

Here's what I changed, broadly speaking:

  • Remove references to components as "glimmer components"
  • Remove most of the sections explaining editions, since it's covered in our new main site pages
  • Added some more structure. Each major section has "benefits" and "getting used to..."
  • Edited for conciseness where possible
  • Fixed up some small accessibility things
  • reformatted very long bulleted lists
  • took out typescript reference

If this seems good, I can follow up with a second pass that aims to replace about half the code examples with links to existing sections in the Guides. I think many of the sections of the Components explanations can be a quick TLDR and advising to read the section of the "real" Guides in full.

@jenweber jenweber requested a review from pzuraq May 20, 2019 02:23
Copy link
Member

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of edits...phew! Great job! 👍

@rwjblue
Copy link
Contributor

rwjblue commented May 24, 2019

@jenweber - Any objections to landing? Happy to keep iterating but this has lots of good fixes already...

@locks locks merged commit 83beb0c into octane May 25, 2019
@locks locks deleted the octane-revisions branch May 25, 2019 08:57
@locks
Copy link
Contributor

locks commented May 25, 2019

Round 2, begin!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants