Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Switch to pnpm #82

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Switch to pnpm #82

merged 1 commit into from
Mar 6, 2025

Conversation

jrjohnson
Copy link
Contributor

New lockfile and then pulled the current pnpm addon blueprint changes ember addon --pnpm in to update everywhere else yarn was mentioned. The only change from the default pnpm addon blueprint is that I went with pnpm v9 for CI.

@jrjohnson
Copy link
Contributor Author

This is sitting in draft as I'm not having any luck finding anyone who can release this addon. I want to do a release of current master before making too many other changes.

@betocantu93
Copy link

Also we no longer need ember-modifier-manager-polyfill this addon supports 4.12+ and this polyfill is inert from 3.8

@RobbieTheWagner
Copy link
Member

I cut a new release, so please proceed with this!

New lockfile and then pulled the current pnpm addon blueprint changes in
to update everywhere else yarn was mentioned.
@jrjohnson jrjohnson marked this pull request as ready for review March 5, 2025 19:37
@jrjohnson
Copy link
Contributor Author

Excellent! I rebased, CI doesn't seem to be running though. Not sure why.

@RobbieTheWagner
Copy link
Member

This all looks good to me! I am not sure why CI is not running either, but maybe merging it will run it.

@RobbieTheWagner RobbieTheWagner merged commit d236d21 into emberjs:master Mar 6, 2025
@jrjohnson jrjohnson deleted the pnpm branch March 6, 2025 18:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants