[BUGFIX beta] Change preference in positional parameters #12350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| for (let i = 0; i < positionalParams.length; i++) { | ||
| let param = params[paramsStartIndex + i]; | ||
| if (!(positionalParams[i] in attrs)) { |
There was a problem hiding this comment.
I think this should be positionalParams[paramsStartIndex + i].
There was a problem hiding this comment.
There was a problem hiding this comment.
Gotcha, thank you for explaining.
There was a problem hiding this comment.
Can you make this an assertion though?
Basically:
assert(`You cannot specify both a positional param (at position ${i}) and the hash argument \`${positionalParams[i]}\`.`, positonalParams[i] in attrs);Then the tests get updated to something like:
expectAssertion(function() {
runAppend(view);
}, /The message from above, I am too lazy to type/);
This fixes the behaviour when a positional param conflicts conflicts with a hash param.
Serabe
force-pushed
the
positional-parameters
branch
from
3aa9f6e to
9edd17f
Compare
rwjblue
added a commit
that referenced
this pull request
Sep 15, 2015
[BUGFIX beta] Change preference in positional parameters
|
Thank you! |
10 tasks
SaladFork
added a commit
to SaladFork/ember-paper
that referenced
this pull request
Jan 28, 2016
Ideally we wouldn't need a separate `positionalIcon` property and could just use `icon`, but this is not permitted (see emberjs/ember.js#12350)
SaladFork
added a commit
to SaladFork/ember-paper
that referenced
this pull request
Jan 28, 2016
Ideally we wouldn't need a separate `positionalIcon` property and could just use `icon`, but this is not permitted (see emberjs/ember.js#12350)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the behaviour when a positional param conflicts conflicts with
a hash param.