Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add stop_on_invalid_record option #15

Merged
merged 1 commit into from
Apr 27, 2016

Conversation

muga
Copy link
Contributor

@muga muga commented Apr 27, 2016

Add stop_on_invalid_record option

  • This option is false by default.
  • If the option is false, the plugin skips invalid records if it found them.
  • If true, the plugin throws DataException if it found an invalid record. CsvParserPlugin also throws same exception.

@coveralls
Copy link

coveralls commented Apr 27, 2016

Coverage Status

Coverage increased (+3.4%) to 90.323% when pulling e61bcf1 on muga:support_stop_on_invalid_record into 02630bf on civitaspo:master.

@civitaspo
Copy link
Member

This option is false by default.

unn... this change breaks backward compatibility... but, this option should be false by default for the uniformity.

Ok, I release next version as v0.1.0, with CHANGELOG that breaking the backward compatibility.

@civitaspo civitaspo merged commit 8e4cfff into embulk:master Apr 27, 2016
@muga
Copy link
Contributor Author

muga commented Apr 27, 2016

Thank you.

this change breaks backward compatibility... but, this option should be false by default for the uniformity.

Yes, but I believe that's better. And you can change the default value anytime. Up to you:-)

@civitaspo
Copy link
Member

@muga
Copy link
Contributor Author

muga commented Apr 27, 2016

Thank you for quick work 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants