Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support type conversion from floating point numbers to integers #33

Merged
merged 1 commit into from
Sep 12, 2017
Merged

Support type conversion from floating point numbers to integers #33

merged 1 commit into from
Sep 12, 2017

Conversation

civitaspo
Copy link
Member

Fix #32

@muga @sakama
Could you review this?

@coveralls
Copy link

coveralls commented Sep 8, 2017 •
edited
Loading

Coverage Status

Coverage increased (+1.3%) to 97.403% when pulling 629ef3b on support_floating_point_numbers into 83f856f on master.

@civitaspo
Copy link
Member Author

civitaspo commented Sep 9, 2017 •
edited
Loading

openjdk7 and oraclejdk7 tests are failed, but these are not due to this p-r. ref. travis-ci/travis-ci#7884, https://blog.travis-ci.com/2017-08-31-trusty-as-default-status

@civitaspo
Copy link
Member Author

Tests will be fixed by #34 .

@sakama
Copy link
Contributor

sakama commented Sep 11, 2017

@civitaspo Looks good to me. #34 as well.
Thanks for fixing!

@muga
Copy link
Contributor

muga commented Sep 11, 2017

@civitaspo @sakama Sorry to be late but thank you for notifying. This change might be OK for my application.

@civitaspo civitaspo force-pushed the support_floating_point_numbers branch from 629ef3b to 76f0fa1 Compare September 12, 2017 11:27
@civitaspo
Copy link
Member Author

Thanks for the reviews!

@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) to 97.403% when pulling 76f0fa1 on support_floating_point_numbers into 4bbbdbf on master.

@civitaspo civitaspo merged commit 5cb82cd into master Sep 12, 2017
@civitaspo civitaspo deleted the support_floating_point_numbers branch September 12, 2017 11:33
@civitaspo
Copy link
Member Author

released: https://rubygems.org/gems/embulk-filter-expand_json/versions/0.2.1

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@civitaspo @coveralls @sakama @muga