Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

A new feature: cache_provider #41

Merged
merged 7 commits into from
May 1, 2019
Merged

A new feature: cache_provider #41

merged 7 commits into from
May 1, 2019

Conversation

civitaspo
Copy link
Member

@civitaspo civitaspo commented Apr 24, 2019

Description

This feature is to make JsonPath cache configurable.
ref. https://github.com/json-path/JsonPath#cache-spi

In some cases, NOOPCache improve the performance of this plugin by 3 times.
ref. https://twitter.com/taketakeoe/status/1119143084565024769 (Japanese)

TODO

  • Implementation
  • Tests
  • Benchmark
  • README

@civitaspo civitaspo changed the title A new feature: cache_provider [WIP] A new feature: cache_provider Apr 24, 2019
@coveralls
Copy link

coveralls commented Apr 24, 2019

Coverage Status

Coverage decreased (-1.4%) to 95.984% when pulling 47facf6 on make-cache-configurable into 984b768 on master.

@civitaspo civitaspo force-pushed the make-cache-configurable branch from d6c4b30 to 0de1b27 Compare May 1, 2019 16:39
@civitaspo civitaspo force-pushed the make-cache-configurable branch from e8678fc to 9ddb165 Compare May 1, 2019 18:09
@civitaspo civitaspo changed the title [WIP] A new feature: cache_provider A new feature: cache_provider May 1, 2019
@civitaspo civitaspo merged commit 2351f7b into master May 1, 2019
@civitaspo civitaspo deleted the make-cache-configurable branch May 1, 2019 18:15
@civitaspo civitaspo mentioned this pull request May 1, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants