Catch up with Embulk v0.10.6 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ignore the warnings, it also upgrades the "org.embulk.embulk-plugins" to 0.4.2.
|
|
|
I understand the changes. Looks good to me. |
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @civitaspo -san,
Thank you for creating and maintaining this awesome plugin!
As we talked at the meetup, Embulk v0.10, v0.11, and v1.0 would have some incompatibilities from v0.9. This PR is to catch up with the latest v0.10.6. (Yet another PR would come to use
embulk-util-config.)I believe it keeps working with Embulk v0.9.23 even after merging this PR.
Can you take a look at this? This PR is broken down into smaller steps per Git commit. I hope it helps easier understanding.