Add a validation code to check if json_column_name column is string type #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is to add a validation code for checking if the type of a column specified as json_column_name option is string or not.
setExpandedJsonColumns
method requires that the json column is string type. It's nice to have such type validation.To add an unit test for this validation, I removed
final
modifier fromschema
field inTestExpandJsonFilterPlugin
class. But this change might not be bad for us.