Typing overrides #400
Merged
Typing overrides #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scienfitz
reviewed
Oct 11, 2024
Scienfitz
approved these changes
Oct 14, 2024
AVHopp
requested changes
Oct 15, 2024
To avoid ambiguity with built-in typing.override
AdrianSosic
force-pushed
the
typing/override
branch
from
d96577a to
16d2363
Compare
AVHopp
approved these changes
Oct 15, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's replace our
See base classhints with a more modern variant that actually uses the type system, as now enabled via PEP 698. Until we drop Python 3.11, this is achieved via thetyping_extensionsbackport.