Use correct precision in botorch wrapper #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AVHopp
commented
Nov 5, 2024
AdrianSosic
approved these changes
Nov 5, 2024
Scienfitz
approved these changes
Nov 5, 2024
AVHopp
force-pushed
the
fix/dtype_in_botorch_wrapper
branch
from
fb03199 to
2de0bf1
Compare
AVHopp
force-pushed
the
fix/dtype_in_botorch_wrapper
branch
from
2de0bf1 to
4fe0f5e
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the use of
DTypeFloatTorchin the BoTorch Wrapper.Previously, this wrapper converted anything into
float64precision. This can cause troubles an imprecision during the correspondingforwardcall in that function.Note that this is one of the fixes required for GPU support, but since it is an issue on its own, I decided to already create this mini PR.