Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add more metadata #35

Open
4 tasks
rossPatton opened this issue Jul 30, 2020 · 5 comments
Open
4 tasks

Add more metadata #35

rossPatton opened this issue Jul 30, 2020 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rossPatton
Copy link
Member

rossPatton commented Jul 30, 2020

Currently we attach some metadata to each hotline entry, but it's not consistent and most of it is not used. Currently the only data we render on hotline pages are the hotline name, phone number and hours of operation and whether it's a crisis hotline or not (by color)

We should make sure all hotline entries also include the following metadata:

  • Website of hotline
  • Description of the service
  • Text message support, if any
  • Support for multiple phone numbers per service
@rossPatton rossPatton added this to the Not 911 v2.0.0 milestone Jul 30, 2020
@rossPatton rossPatton added enhancement New feature or request good first issue Good for newcomers labels Jul 30, 2020
@jaqarrick
Copy link
Contributor

Hi there! @lizzthabet and I are interested in helping with this issue if you're still looking for contributors! We have a couple questions for the best way to proceed:

  • We see that the metadata for text numbers / instructions are in Phonenumbers.ts. Do you have a preference for how these numbers should render/display in each entry? For example they could render next to the phone numbers like "1-800-555-5555 or text 'MSG' to 5555'
  • Should these text options have any interactivity - clicking the text option could open a texting app on a mobile device, for example - or just display as plain text?
  • As far displaying tags in a helpful way - should the tags just display in blocks somewhere in each entry? Perhaps at the bottom / with some kind of limiting how many are included? Or are you hoping for something more dynamic, like a search/sort options for tags?

This seemed like a good first issue to get started with, but if there are other issues that are more pressing just let us know!

Thanks 😄

@rossPatton
Copy link
Member Author

rossPatton commented Nov 29, 2020

hey @jaqarrick thanks for taking a look at this! Sorry for my slow response - been a little busy with the holiday

to answer your questions:

  1. I don't have a preference myself for how they should render, but I do like your suggestion

  2. Opening a text app would be the preferred functionality. Clicking the phone numbers should open the phone app, so I think users would expect similar functionality for the texting. Even better if you could 'pre-fill' the message for the user

  3. I think for now just displaying the tags would be nice. Maybe like you said, if a number has too many it can just render a "and N more tags" somewhere. Tag search/filter functionality would be fantastic, but not something I would be too concerned about until we have more tags added

thanks for your interest in this project! let me know if there's anything else I can do to help

  • Ross

@jaqarrick
Copy link
Contributor

Hi Ross,

Thanks for getting back to us! We got started on this issue today and added the text field to display next to the phone number. @lizzthabet started a PR. As far as interactivity, we thought it would be nice for the text and website options to each display in their own svg button/icon next to the telephone icon. Are you using a SVG/Icon library and if so, are there icons already available to represent 'text' and 'website'? Thanks!

Jack

jaqarrick added a commit to jaqarrick/project-not-911 that referenced this issue Dec 3, 2020
…so that texting can be interactive in the future
jaqarrick added a commit to jaqarrick/project-not-911 that referenced this issue Dec 10, 2020
…each method of contacting hotlines and link icons to SMS and website URLS
@rossPatton
Copy link
Member Author

Hey @jaqarrick sorry for my slow response => all the icons were done by a volunteer designer. But anything that is in the same vein should be fine!

lizzthabet pushed a commit to jaqarrick/project-not-911 that referenced this issue Dec 14, 2020
…each method of contacting hotlines and link icons to SMS and website URLS
lizzthabet pushed a commit to jaqarrick/project-not-911 that referenced this issue Dec 15, 2020
…each method of contacting hotlines and link icons to SMS and website URLS
@lizzthabet
Copy link
Contributor

@rossPatton, thanks! We ended using open source icons from Bootstrap. The PR #51 is ready for review, if you want to take a look and let us know what next steps are. Any feedback is appreciated!

rossPatton pushed a commit that referenced this issue Dec 28, 2020
* Issue #35: Add SMS text field to display for each hotline

* Issue #35: Refactor data structure of text contact info so that texting can be interactive in the future

* Issue #35: Add IconGroup component to display icons for each method of contacting hotlines and link icons to SMS and website URLS

* No linked issue: replace en dash with hyphen in phone number hotline constants

Co-authored-by: jaqarrick <pigmaask@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants