[pinpoint-apm#9575] Refactor AsyncTrace

emeroad · Jan 13, 2023 · c0ad587 · c0ad587
1 parent 33191a1
commit c0ad587
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 15 deletions.
diff --git a/...straps/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/util/ScopeUtils.java b/...straps/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/util/ScopeUtils.java
@@ -60,4 +60,15 @@ public static boolean hasScope(final Trace trace, final String scopeName) {
         final TraceScope scope = trace.getScope(scopeName);
         return scope != null;
     }
+
+    public static boolean addScope(Trace trace, String scopeName) {
+        // add async scope.
+        final TraceScope oldScope = trace.addScope(scopeName);
+        if (oldScope != null) {
+            // delete corrupted trace.
+//            deleteAsyncTrace(trace);
+            return false;
+        }
+        return true;
+    }
 }
diff --git a/...pinpoint/profiler/context/ScopeUtils.java → ...int/profiler/context/AsyncScopeUtils.java b/...pinpoint/profiler/context/ScopeUtils.java → ...int/profiler/context/AsyncScopeUtils.java
@@ -5,13 +5,13 @@
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 
-public final class ScopeUtils {
-    private static final Logger logger = LogManager.getLogger(ScopeUtils.class);
+public final class AsyncScopeUtils {
+    private static final Logger logger = LogManager.getLogger(AsyncScopeUtils.class);
 
-    private ScopeUtils() {
+    private AsyncScopeUtils() {
     }
 
-    public static boolean nestedScope(Trace trace, String scopeName) {
+    public static boolean nested(Trace trace, String scopeName) {
         // add async scope.
         final TraceScope oldScope = trace.addScope(scopeName);
         if (oldScope != null) {

diff --git a/profiler/src/main/java/com/navercorp/pinpoint/profiler/context/DefaultAsyncContext.java b/profiler/src/main/java/com/navercorp/pinpoint/profiler/context/DefaultAsyncContext.java
@@ -89,7 +89,7 @@ private Trace newAsyncContextTrace(Reference<Trace> reference) {
             logger.debug("asyncTraceContext.continuAsyncTraceObject(e) AsyncTrace:{}", asyncTrace);
         }
 
-        if (ScopeUtils.nestedScope(asyncTrace, ASYNC_TRACE_SCOPE)) {
+        if (AsyncScopeUtils.nested(asyncTrace, ASYNC_TRACE_SCOPE)) {
             return null;
         }
 
@@ -112,21 +112,15 @@ private void bind(Reference<Trace> reference, Trace asyncTrace) {
 
     @Override
     public Trace currentAsyncTraceObject() {
-        final Reference<Trace> reference = currentTraceObject();
-        return reference.get();
-    }
-
-
-    private Reference<Trace> currentTraceObject() {
         final Reference<Trace> reference = binder.get();
         final Trace trace = reference.get();
         if (trace == null) {
-            return DefaultReference.emptyReference();
+            return null;
         }
         if (trace.canSampled()) {
-            return reference;
+            return trace;
         }
-        return DefaultReference.emptyReference();
+        return null;
     }
 
 

diff --git a/profiler/src/main/java/com/navercorp/pinpoint/profiler/context/DisableAsyncContext.java b/profiler/src/main/java/com/navercorp/pinpoint/profiler/context/DisableAsyncContext.java
@@ -43,7 +43,7 @@ private Trace newAsyncContextTrace(Reference<Trace> reference) {
             logger.debug("asyncTraceContext.continueDisableAsyncContextTraceObject() AsyncTrace:{}", asyncTrace);
         }
 
-        if (ScopeUtils.nestedScope(asyncTrace, ASYNC_TRACE_SCOPE)) {
+        if (AsyncScopeUtils.nested(asyncTrace, ASYNC_TRACE_SCOPE)) {
             return null;
         }