Gracefully handle and report failure to reload config #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vilhalmer
commented
Jun 15, 2018
config.c
Outdated
| wl_list_for_each_safe(criteria, tmp, &new_config.criteria, link) { | ||
| wl_list_remove(&criteria->link); | ||
| wl_list_insert(config->criteria.prev, &criteria->link); | ||
| } |
There was a problem hiding this comment.
This is a little gross, but I thought it was worth it to avoid just doing the parsing again. That is an alternative, however.
There was a problem hiding this comment.
Hmm, I think you can do it with wl_list_insert_list
There was a problem hiding this comment.
Good call, I forgot that was there.
emersion
reviewed
Jun 15, 2018
dbus/mako.c
Outdated
| } | ||
|
|
||
| static const sd_bus_vtable service_vtable[] = { | ||
| SD_BUS_VTABLE_START(0), | ||
| SD_BUS_METHOD("DismissAllNotifications", "", "", handle_dismiss_all_notifications, SD_BUS_VTABLE_UNPRIVILEGED), | ||
| SD_BUS_METHOD("DismissLastNotification", "", "", handle_dismiss_last_notification, SD_BUS_VTABLE_UNPRIVILEGED), | ||
| SD_BUS_METHOD("InvokeAction", "s", "", handle_invoke_action, SD_BUS_VTABLE_UNPRIVILEGED), | ||
| SD_BUS_METHOD("Reload", "", "", handle_reload, SD_BUS_VTABLE_UNPRIVILEGED), | ||
| SD_BUS_METHOD("Reload", "", "b", handle_reload, SD_BUS_VTABLE_UNPRIVILEGED), |
There was a problem hiding this comment.
Would it be better to use dbus errors instead of return values?
There was a problem hiding this comment.
I didn't know those existed, but probably!
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reload_configreturn a booleanmakoctlappropriatelyFixes #44.