Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Don't use all-caps identifiers with a leading underscore #97

Merged
merged 1 commit into from
Nov 24, 2018
Merged

Don't use all-caps identifiers with a leading underscore #97

merged 1 commit into from
Nov 24, 2018

Conversation

emersion
Copy link
Owner

Fixes #72

@emersion emersion requested a review from vilhalmer November 24, 2018 13:38
vilhalmer
vilhalmer approved these changes Nov 24, 2018
View reviewed changes
Copy link
Collaborator

@vilhalmer vilhalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emersion emersion merged commit c75eba6 into master Nov 24, 2018
@emersion emersion deleted the identifier-violation branch November 24, 2018 13:58
@elfring
Copy link

elfring commented Nov 24, 2018

Thanks for your adjustment of affected include guards.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vilhalmer vilhalmer vilhalmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emersion @elfring @vilhalmer