Improve homescreen backlighting to depend on external light #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibault-ml
force-pushed
the
improve-homescreen-backlight
branch
from
0830546
to
2ac78d8
Compare
|
Ideally the code for reading the light sensor should be put into a function in onboard.py, similar to the battery voltage sensor. |
thibault-ml
force-pushed
the
improve-homescreen-backlight
branch
from
2ac78d8
to
5dfac57
Compare
|
@thinkl33t Thanks, I was using what was already there, but I've now changed it to use what already exists: |
thibault-ml
force-pushed
the
improve-homescreen-backlight
branch
from
5dfac57
to
75c2a1f
Compare
| ugfx.backlight(70) | ||
| l = onboard.get_light() | ||
|
|
||
| lum_percent = int(l * 100 / 4095) |
There was a problem hiding this comment.
Can this be put into a function in onboard.py similar to the battery percentage one? Once it is i think it should be mergeble :)
Instead of relying on what power remains in the battery, rely instead on the external lighting to adapt the brightness of the screen. Note that this might need a bit more fine-tuning.
thibault-ml
force-pushed
the
improve-homescreen-backlight
branch
from
75c2a1f
to
da6d8e0
Compare
|
@thinkl33t Thanks, updated! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on what power remains in the battery, rely instead on the external lighting to adapt the brightness of the screen.
Note that this might need a bit more fine-tuning.