-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merge Full/:-> into a single type #31
base: master
Are you sure you want to change the base?
Conversation
Still doesn't compile on 7.10 because base 4.9 now has polykinded |
Thank you for this PR! I want to see how this plays out in raw-feldspar. This will take some time, but I'll try to be quick. I think we should define our own poly-kinded I guess 7.8 is out of question? (Can never remember which features were introduced when.) |
Seems 7.8 is failing for a different reason (something about Typeable 'Full), I'll see if it can be fixed up. |
Wow, this too way longer than expected... For some reason I was expecting to have to make changes in RAW-Feldspar, but all I needed was to turn on I'll be happy to merge. Could you perhaps just smash the commits into a single one with a more descriptive message? Thanks |
Oh right, there was also the 7.8 issue. Any progress on that? |
For your interest, this seems to compile with minimal changes. I've left alone classes like Syntactic for the most part, and simply restricted the kind where necessary to Sig Type -> Type, for example in the eval class, where the AST data type itself is still kind polymorphic.
The only casualty is Functor (AST sym) which I guess is now some other type of functor potentially? Any ideas there?