Custom path for ARM devices with limited space #21

horstle · 2018-04-20T21:05:08Z

#20

emilsvennesson · 2018-05-23T18:46:01Z

I will review this before the week is over... sorry for taking so long.

witzatom · 2018-12-23T11:25:43Z

I could really use this feature.

dagwieers · 2019-08-19T12:28:31Z

Can you please rebase?

horstle · 2019-08-19T20:20:11Z

Done.

horstle · 2019-08-22T09:23:50Z

The lint issues in Travis are no issues of this PR.
The first one (no-member) is just wrong, xbmcgui.Dialog().browseSingle() does exist.
The second is simply not created by this PR, as it doesn't change the corresponding lines.

See next comment.

horstle · 2019-08-23T15:01:05Z

Alright, all pylint issues are gone, but the too-many-lines and too-many-statements (at _install_widevine_arm()) are simply suppressed and should be addressed in the future.

The first argument of xbmcgui.Dialog().browseSingle() is actually called "type" in the documentation, but since "type" already exists, I had to rename it (to "atype"). I don't think this could create an issue, because from what I understand if somebody ever called browseSingle() with a keyword-argument type= he would redefine the builtin.

mediaminister · 2019-09-13T07:36:41Z

@horstle While testing your pull request I came to the conclusion that there is no option to use the default temporary directory again when a custom directory was set once.
Setting the default temp directory as default in the settings.xml fixes this, so there is no need any more to call this setting "custom". We can rely completely on settings.xml to define the temp directory.

I'll add a commit to this pull request which implements this.

mediaminister · 2019-09-13T08:54:37Z

This should be ready to merge now. Please test this first on ARM devices.

lib/inputstreamhelper/__init__.py

dagwieers

Looking good. Just a few remarks, nothing critical.

resources/settings.xml

test/xbmc.py

test/xbmcgui.py

dagwieers · 2019-09-14T14:08:47Z

I think I fixed the coverage reporting now. Thanks for your patience!
If you would rebase your branch (git pull --rebase origin master) and force-push, I am confident all goes green (not that it really matters, but would be a nice test).

Add possibility to change temporary path on ARM devices if the ChromeOS image is too big. Remember custom path (as setting), check specified custom path whether there is enough space.

dagwieers · 2019-09-14T15:03:34Z

@horstle I did the rebase and pushed one commit with the changes I proposed here.

This commit includes:

Change temp_dir info temp_path
Use special://masterprofile instead of special://profile
Fix disabled setting
Use standard argument name for xbmcgui.browseSingle
Rename 'Temporary directory' into 'Temporary download directory'
Translation to Dutch

Please do not force-push :-)

dagwieers · 2019-09-14T15:17:22Z

I think we may want to reorganize the settings at some point.
Probably add a seperator, and rename 'Troubleshooting' into 'Expert'.

dagwieers

For me this is ready to be merged. Even if we decide to make this hidden for non-ARM platforms later.

This commit includes: - Change `temp_dir` info `temp_path` - Use `special://masterprofile` instead of `special://profile` - Fix `disabled` setting - Use standard argument name for xbmcgui.browseSingle - Rename 'Temporary directory' into 'Temporary download directory'

mediaminister · 2019-09-14T16:44:03Z

If people with ARM devices can confirm this works in real life, I'm okay with merging this.

dagwieers · 2019-09-14T17:54:56Z

I have tested this, but not with a device that hasn't sufficient disk space.

horstle · 2019-09-15T19:02:17Z

Great to see this finally merged, thanks! I really hope I didn't break anything with the last changes.

dagwieers · 2019-09-15T19:05:42Z

We still have time for testing before we release. It would be nice to test the following cases:

Test with insufficient disk space
Point to a new temporary path (potentially on other storage)
Test with second storage that also does not have insufficient disk space
Remove second storage with temporary path still pointing to it
Test with non-existing temporary path

leosmeira mentioned this pull request Jul 11, 2018

[Feature Request] Custom path for tmp #20

Closed

horstle force-pushed the custom_path branch 2 times, most recently from d0f89e0 to 910529b Compare February 18, 2019 00:47

dagwieers added the bug label Aug 15, 2019

dagwieers modified the milestones: Future, 0.5.0 Aug 18, 2019

dagwieers added the arm Related to ARM architecture label Aug 19, 2019

dagwieers mentioned this pull request Aug 19, 2019

Add options to run manually and force a reinstall via the settings page. #52

Closed

horstle force-pushed the custom_path branch from 0ef3e6b to 29e0b20 Compare August 19, 2019 20:12

horstle force-pushed the custom_path branch 2 times, most recently from 8fc4d77 to b2349f0 Compare August 19, 2019 21:10

dagwieers mentioned this pull request Aug 20, 2019

Upcoming release management #85

Closed

horstle force-pushed the custom_path branch 3 times, most recently from 83eed36 to cc60536 Compare August 22, 2019 09:06

horstle mentioned this pull request Aug 23, 2019

Implement settings menu and API #91

Merged

horstle force-pushed the custom_path branch 7 times, most recently from 2690f5a to 55b4593 Compare August 23, 2019 14:46

horstle force-pushed the custom_path branch from f318760 to a01ae4b Compare September 12, 2019 20:02

mediaminister force-pushed the custom_path branch from a01ae4b to bc8c555 Compare September 13, 2019 08:48

mediaminister force-pushed the custom_path branch from bc8c555 to 071cacc Compare September 13, 2019 09:00

horstle commented Sep 13, 2019

View reviewed changes

lib/inputstreamhelper/__init__.py Outdated Show resolved Hide resolved

horstle force-pushed the custom_path branch 2 times, most recently from 7fada2f to 10e3881 Compare September 13, 2019 20:54

dagwieers reviewed Sep 14, 2019

View reviewed changes

resources/settings.xml Outdated Show resolved Hide resolved

resources/settings.xml Outdated Show resolved Hide resolved

test/xbmc.py Outdated Show resolved Hide resolved

test/xbmcgui.py Outdated Show resolved Hide resolved

horstle added 2 commits September 14, 2019 17:00

Possibility to change temporary path.

2d7d6b2

Add possibility to change temporary path on ARM devices if the ChromeOS image is too big. Remember custom path (as setting), check specified custom path whether there is enough space.

Small change to _temp_path(), revert if you don't like it.

09dbb46

dagwieers force-pushed the custom_path branch from 10e3881 to 8f73424 Compare September 14, 2019 15:03

dagwieers force-pushed the custom_path branch from 8f73424 to 3235a3a Compare September 14, 2019 15:05

dagwieers force-pushed the custom_path branch from 3235a3a to 15e31eb Compare September 14, 2019 15:20

dagwieers approved these changes Sep 14, 2019

View reviewed changes

dagwieers mentioned this pull request Sep 14, 2019

Widevine extraction on ARM now needs 2.7GiB #168

Closed

dagwieers force-pushed the custom_path branch from 15e31eb to 752c263 Compare September 14, 2019 15:37

Small fixes

a64a360

This commit includes: - Change `temp_dir` info `temp_path` - Use `special://masterprofile` instead of `special://profile` - Fix `disabled` setting - Use standard argument name for xbmcgui.browseSingle - Rename 'Temporary directory' into 'Temporary download directory'

dagwieers force-pushed the custom_path branch from 752c263 to a64a360 Compare September 14, 2019 15:38

dagwieers merged commit adb66aa into emilsvennesson:master Sep 14, 2019

dagwieers modified the milestones: v0.5.0, v0.4.3 Sep 14, 2019

horstle deleted the custom_path branch September 15, 2019 19:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom path for ARM devices with limited space #21

Custom path for ARM devices with limited space #21

horstle commented Apr 20, 2018 •

edited

Loading

emilsvennesson commented May 23, 2018

witzatom commented Dec 23, 2018

dagwieers commented Aug 19, 2019

horstle commented Aug 19, 2019

horstle commented Aug 22, 2019 •

edited

Loading

horstle commented Aug 23, 2019

mediaminister commented Sep 13, 2019

mediaminister commented Sep 13, 2019

dagwieers left a comment

dagwieers commented Sep 14, 2019

dagwieers commented Sep 14, 2019 •

edited

Loading

dagwieers commented Sep 14, 2019

dagwieers left a comment •

edited

Loading

mediaminister commented Sep 14, 2019

dagwieers commented Sep 14, 2019

horstle commented Sep 15, 2019

dagwieers commented Sep 15, 2019

Custom path for ARM devices with limited space #21

Custom path for ARM devices with limited space #21

Conversation

horstle commented Apr 20, 2018 • edited Loading

emilsvennesson commented May 23, 2018

witzatom commented Dec 23, 2018

dagwieers commented Aug 19, 2019

horstle commented Aug 19, 2019

horstle commented Aug 22, 2019 • edited Loading

horstle commented Aug 23, 2019

mediaminister commented Sep 13, 2019

mediaminister commented Sep 13, 2019

dagwieers left a comment

Choose a reason for hiding this comment

dagwieers commented Sep 14, 2019

dagwieers commented Sep 14, 2019 • edited Loading

dagwieers commented Sep 14, 2019

dagwieers left a comment • edited Loading

Choose a reason for hiding this comment

mediaminister commented Sep 14, 2019

dagwieers commented Sep 14, 2019

horstle commented Sep 15, 2019

dagwieers commented Sep 15, 2019

horstle commented Apr 20, 2018 •

edited

Loading

horstle commented Aug 22, 2019 •

edited

Loading

dagwieers commented Sep 14, 2019 •

edited

Loading

dagwieers left a comment •

edited

Loading