Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Handle IPv6 on Linux #2

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Conversation

gmlewis
Copy link
Contributor

@gmlewis gmlewis commented Jun 18, 2021

Fixes: #1.

This PR makes all unit tests pass on Linux.

See discussion in https://github.com/github/gh-ost/pull/143/files for handling of IPv6 in Go.

@gmlewis
Copy link
Contributor Author

gmlewis commented Jun 18, 2021

It looks like AppVeyor is using Go 1.10, but github.com/stretchr/testify/assert requires at least Go 1.13.

Copy link
Contributor

@kelindar kelindar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kelindar kelindar merged commit 3c15880 into emitter-io:master Jun 18, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests fail on Linux Mint Cinnamon 19.3
2 participants