Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature/programmatic closure #25

Merged

Conversation

jameswhoughton
Copy link
Contributor

Fixed rare bug where a timeout of a dismissed notification can close a new notification prematurely

Update notify() to return a function allowing the notification to be closed programmatically

As notification IDs are incremental, in rare cases old timeouts can affect new notifications (if old notification is dismissed).
Allows a notification to be closed programmatically
@emmanuelsw emmanuelsw merged commit 21b6c18 into emmanuelsw:main Jun 9, 2022
@emmanuelsw
Copy link
Owner

Thank you @Jimjam89!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants