NotificationGroup: fix extraneous non-props warning in Vue 3.5+ #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vue's devtools auto add a data-v-inspector prop to components as a form of Sourcemap.
As of Vue 3.5+, for NotificationGroup this was causing a warning of 'Extraneous non-props attributes ("data-v-inspector") were passed to component but could not be automatically inherited because component renders fragment or text root nodes.'
|
Thank you! This will fix the issue we currently have. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a warning when used in Vue 3.5+.
Vue's devtools auto add a
data-v-inspectorprop to components as a form of Sourcemap.As of Vue 3.5+, for NotificationGroup this was causing a warning of 'Extraneous non-props attributes ("data-v-inspector") were passed to component but could not be automatically inherited because component renders fragment or text root nodes.'
Similar to this Nuxt PR, this PR disables 'automatically inherit attributes', as by default in Vue extra attributes added to
<NotificationGroup something="x">would attempt to addsomethingas an attribute on the root node, butNotificationGroup's root node is a<template>which can't receive attributes.