Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[unitless] Convert to TypeScript #2430

Merged

Conversation

sarayourfriend
Copy link
Contributor

What: Converts unitless to TypeScript

Why: Part of #2358

How: Rename index.js to index.ts and add an as const to get stricter type declaration declared (instead of the weak string: 1 that the flow types previously had).

Checklist:

  • Documentation N/A
  • Tests N/A
  • Code complete
  • Changeset

For the tests to run it will depend on changes in #2427 but figured I'd throw this up anyway

@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2021

🦋 Changeset detected

Latest commit: 5eeb141

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@emotion/unitless Minor
@emotion/serialize Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 13, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5eeb141:

Sandbox Source
Emotion Configuration

@Andarist Andarist merged commit fc4d27c into emotion-js:ts-migration Aug 14, 2021
@github-actions github-actions bot mentioned this pull request May 17, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants