-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix some TS things #2559
Fix some TS things #2559
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0652f74:
|
Codecov Report
|
"packages/*/types/test/*", | ||
"packages/*/types/test*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what the second one is doing here? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not all of the type tests are in a test directory, maybe the first one is unnecessary, idk how TS's globs work
The main reason I see to stick with I'm using the strategy that you have mentioned in other repos but mostly because I was too lazy to set up |
If we can easily upgrade, sure I guess |
# Conflicts: # .github/workflows/main.yml
Some misc fixes to things:
as const
, the keys aren't what you want from the types.@ts-expect-error
for when we expect errors and probably just a function like<T>(t: T) => void
to assert types (i know that's not really correct but it's probably good enough for our cases)