Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(subscription): add MQTT5 prop subscription support #739

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

oceanlvr
Copy link
Contributor

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

None.

Issue Number

#688

What is the new behavior?

Support MQTT5 subscription option, see mqtt.js API:

https://github.com/mqttjs/MQTT.js#mqttclientsubscribetopictopic-arraytopic-object-options-callback

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@oceanlvr oceanlvr added the feature This pr is a feature label Oct 14, 2021
@oceanlvr oceanlvr requested a review from ysfscream October 14, 2021 14:15
@oceanlvr oceanlvr self-assigned this Oct 14, 2021
@ysfscream ysfscream merged commit 278bdcd into emqx:master Oct 18, 2021
@oceanlvr oceanlvr deleted the form/fix branch January 20, 2022 07:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature This pr is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants