fix(service): refactor delete API #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oceanlvr
commented
Oct 29, 2021
| return | ||
| } | ||
| return await this.messageRepository.remove(query) | ||
| await this.messageRepository.delete(query.map((entity) => entity.id) as string[]) |
There was a problem hiding this comment.
remove does not support a count of more than 1000 entity deletion.
There was a problem hiding this comment.
So the reason why you can't clear the message is that you're using the wrong API and there's no limit to the number of messages after the current change remove to delete?
There was a problem hiding this comment.
Yes,delete won't check the entity exist or not, just follow the id field and there is no delete count limit.
- remove, return the data deleted, and count <
1000once, it's safe but slow. - delete, don't check anything, so you should check id exists before deleting. it's unsafe but quick and has no limit on counting.
ysfscream
approved these changes
Oct 29, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
If you have any questions, you can refer to the Contributing Guide
What is the current behavior?
delete message > 1000 work as we expect.
Issue Number
#749
What is the new behavior?
Please describe the new behavior or provide screenshots.
Does this PR introduce a breaking change?
Specific Instructions
Are there any specific instructions or things that should be known prior to review?
Other information