WIP: feat(connection): support rest connection props #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysfscream
reviewed
Nov 30, 2021
| @@ -485,6 +543,8 @@ import _ from 'lodash' | |||
| import time from '@/utils/time' | |||
| import useServices from '@/database/useServices' | |||
|
|
|||
| type UserPairObect = { key: string; value: string; checked: boolean } | |||
There was a problem hiding this comment.
Looks like this type was defined in the MsgPublish.vue, Why not set it to common?
ysfscream
reviewed
Nov 30, 2021
Comment on lines
+371
to
+394
| <el-form-item :label="$t('connections.userProperties')"> | ||
| <div class="user-props"> | ||
| <el-button icon="el-icon-plus" class="btn-props-plus" type="text" @click="addItem" /> | ||
| <div v-for="(item, index) in listData" class="user-props-row" :key="index"> | ||
| <a class="btn-check" @click="checkItem(index)"> | ||
| <i v-if="item.checked" class="iconfont el-icon-check"></i> | ||
| <i v-else class="iconfont el-icon-check disable-icon"></i> | ||
| </a> | ||
| <el-input | ||
| placeholder="key" | ||
| size="mini" | ||
| v-model="item.key" | ||
| class="input-user-prop user-prop-key" | ||
| /> | ||
| <el-input | ||
| placeholder="value" | ||
| size="mini" | ||
| v-model="item.value" | ||
| class="input-user-prop user-prop-value" | ||
| /> | ||
| <el-button icon="el-icon-delete" class="btn-delete" type="text" @click="deleteItem(index)" /> | ||
| </div> | ||
| </div> | ||
| </el-form-item> |
There was a problem hiding this comment.
This part of the form item was used on the meta card. And the add & delete logics were the same. So, I think making it to a common component is better. Just need a bind value.
ysfscream
reviewed
Nov 30, 2021
Comment on lines
+579
to
+595
| public listData: UserPairObect[] = [_.cloneDeep(this.defaultPropObj)] | ||
|
|
||
| private checkItem(index: number) { | ||
| this.listData[index].checked = !this.listData[index].checked | ||
| } | ||
|
|
||
| private deleteItem(index: number) { | ||
| if (this.listData.length > 1) { | ||
| this.listData.splice(index, 1) | ||
| } else if (this.listData.length === 1) { | ||
| this.listData = [_.cloneDeep(this.defaultPropObj)] | ||
| } | ||
| } | ||
|
|
||
| private addItem() { | ||
| this.listData.push(_.cloneDeep(this.defaultPropObj)) | ||
| } |
These properties are not important in this version. Just ignore them temporarily, but you can store them. |
ysfscream
approved these changes
Dec 1, 2021
|
I merge first, the next PR or Version modification. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
If you have any questions, you can refer to the Contributing Guide
What is the current behavior?
TODO:
How to design the UI for both properties?
Issue Number
Example: #123
What is the new behavior?
Please describe the new behavior or provide screenshots.
Does this PR introduce a breaking change?
Specific Instructions
Are there any specific instructions or things that should be known prior to review?
Other information