-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Extend embuilder deferred building mode to ports #23924
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Open
dschuff
wants to merge
19
commits into
emscripten-core:main
Choose a base branch
from
dschuff:ports-deferred
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
021e0cc
Allow deferred/combined building of ports with system_libs.
dschuff ba2b0d6
use a global in cache/__init__.py instead
dschuff f6e3bdd
Use separate build directories for ports variants
dschuff eb3101c
clean up, work around lack of str.removeprefix
dschuff 830eddb
Use lib archive path/name instead of variant name to separate directo…
dschuff 7082238
remove unused argument
dschuff 060947e
Merge branch 'main' into ports-deferred
dschuff 0ad6f2c
remove unnecessary file deletion
dschuff 36090e3
fix ruff
dschuff 94648d8
remove unneeded ensure_dirs
dschuff 6d36a65
Merge branch 'main' into ports-deferred
dschuff 75b1151
Use global
dschuff 3e52a80
skip ports.get to avoid redundant header install
dschuff ca3585e
skip ports.get when embuilder
dschuff a4d161e
Merge branch 'main' into ports-deferred
dschuff 031ff61
Merge branch 'main' into ports-deferred
dschuff 6faa8a5
Merge branch 'main' into ports-deferred
dschuff 1772acd
Put back assertion
dschuff a6944b4
Merge branch 'main' into ports-deferred
dschuff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So its not currently possible use ninja in non-deferred mode? I guess thats OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ninja still works in non-deferred mode. If you do
EMCC_USE_NINJA=1 test/runner.py core0
it will build the libraries on-demand in non-deferred mode with ninja. Deferred mode only makes sense when using embuilder though.