[WebGL] blitOffscreenFramebuffer: handle already-deleted program #23980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See comment for explanation. Fixes 23654. See the other PR for additional discussion: emscripten-core#23658 (comment)
|
Unfortunately yes, due to OpenGL's rules I think this is the best that can be done in this situation. |
|
Thank you for the confirmation Ken! |
kripken
approved these changes
Apr 10, 2025
Most objects (like buffers) are automatically unbound when they're deleted. Not so for programs. Also, IIRC, not so for bindings that exist inside of a VAO if that VAO is not current (so the binding is not active, but can be reactivated by activating the VAO). I think that case behaves similarly. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comment for explanation.
Issue: #23654
See the other PR for additional discussion: #23658 (comment)