Skip to content

Rename some JS libraries to match their native counterparts. NFC #24069

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Apr 8, 2025

No description provided.

@sbc100 sbc100 requested review from dschuff and kripken April 8, 2025 17:04
@kripken
Copy link
Member

kripken commented Apr 8, 2025

Does this not affect e.g. ./emcc test/hello_world.c -lxlib.js? That works now but after this change it would need to be ./emcc test/hello_world.c -lX11.js

@sbc100
Copy link
Collaborator Author

sbc100 commented Apr 8, 2025

Does this not affect e.g. ./emcc test/hello_world.c -lxlib.js? That works now but after this change it would need to be ./emcc test/hello_world.c -lX11.js

Yes, that is true. However, the standard way that this library was includes has always been via -lX11 (without the .js suffix). I dont think that folks are generally including system libraries via -lxlib.js, but I guess its worth considering more and at least adding a changelog entry.

@sbc100 sbc100 changed the title Rename come JS libraries to match their native counterparts. NFC Rename some JS libraries to match their native counterparts. NFC Apr 15, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants