Pass -DENABLE_WERROR=0 when building Binaryen #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are experiencing an issue at our Unity CI with building Binaryen: WebAssembly/binaryen#4588 It seems that for end users, disabling -Werror is a good general measure to enable wider chance of success to build. Emsdk installations are unlikely to be used by Binaryen developers to iterate on Binaryen development, so it is not necessary there?
sbc100
approved these changes
Apr 13, 2022
|
I don't know how many end users directly git clone Binaryen to use it, though generally I do recommend -Werror to be a setting that developers and CI would have enabled, and end users would by default get disabled. It can be tricky to simultaneously set up a "developers by default get -Werror on and end users by default get -Werror off" if both users follow the same setup steps. But it is probably good to assume that most people installing via emsdk will be end users, and most people git cloning binaryen directyl would be developers. So maybe Binaryen repo could default to having -Werror enabled, and then emsdk can disable it by default. |
3 tasks
torokati44
added a commit
to torokati44/binaryen-feedstock
that referenced
this pull request
Sep 1, 2022
This was referenced Sep 1, 2022
torokati44
added a commit
to torokati44/binaryen-feedstock
that referenced
this pull request
Sep 1, 2022
torokati44
added a commit
to torokati44/binaryen-feedstock
that referenced
this pull request
Sep 1, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are experiencing an issue at our Unity CI with building Binaryen: WebAssembly/binaryen#4588
It seems that for end users, disabling -Werror is a good general measure to enable wider chance of success to build. Emsdk installations are unlikely to be used by Binaryen developers to iterate on Binaryen development, so it is not necessary there?