Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

3D-mode fix #1069

Merged
merged 2 commits into from
Jul 12, 2024
Merged

3D-mode fix #1069

merged 2 commits into from
Jul 12, 2024

Conversation

nerdCopter
Copy link
Member

@nerdCopter nerdCopter commented Jun 18, 2024 •
edited
Loading

  • this seems to have fixed it. motor output signals are correct.
  • needs 3D flight testing and feedback
  • please test https://github.com/emuflight/dev-unstable/releases/tag/20240618.193242-hex
  • Tested good without props on BLHeli32 32.9.5 and BlueJay 0.16.
  • Tested good with props on Bluejay 0.16. I did not "fly", but it rotates each axis properly and was able to hover inverted.
  • BlueJay 0.17, 0.18, 0.19 are known to have broken 3D startup power. Seemingly fixed in BlueJay 0.21-RC1, but BlueJay developers would like BlackBox logs for further analysis.

Please test-fly and report feedback this PR or Discord.

image
configurator-output-testing

@nerdCopter nerdCopter added in-testing-needs-testing needs testing before merge consideration 0.4.3 labels Jun 18, 2024
@nerdCopter nerdCopter marked this pull request as ready for review July 8, 2024 15:36
@nerdCopter nerdCopter mentioned this pull request Jul 9, 2024
Closed
@nerdCopter nerdCopter requested a review from Quick-Flash July 9, 2024 16:37
@nerdCopter
Copy link
Member Author

my initial commit was proper, so force-pushed it.

@nerdCopter
Copy link
Member Author

merging this, i tested enough to feel comfortable and no one stepping up to test it.

@nerdCopter nerdCopter merged commit 189d2bd into emuflight:master Jul 12, 2024
6 checks passed
@nerdCopter nerdCopter deleted the 20220612_3D_fix branch July 12, 2024 13:24
@nerdCopter
Copy link
Member Author

Augenstern_3D_test_MVI_0108.mp4

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Quick-Flash Quick-Flash Awaiting requested review from Quick-Flash

Assignees
No one assigned
Labels
0.4.3 in-testing-needs-testing needs testing before merge consideration
Projects
None yet
Milestone
No milestone
1 participant
@nerdCopter