Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

PLAT-129601: Upgrade react-refresh-webpack-plugin 0.3.3 to 0.4.3 #231

Merged
merged 6 commits into from
Jan 13, 2021

Conversation

hong6316
Copy link
Contributor

@hong6316 hong6316 commented Dec 30, 2020

Issue Resolved / Feature Added

When update react-refresh-webpack-pugin module to 0.4.1, we have "Module not found: Can't resolve 'react-refresh/runtime" error.

Resolution

Update the module to 0.4.3.

Additional Considerations

Links

PLAT-129601

Comments

Enact-DCO-1.0-Signed-off-by: Taeyoung Hong (taeyoung.hong@lge.com)

@hong6316 hong6316 requested a review from MikyungKim December 30, 2020 02:07
@MikyungKim MikyungKim changed the base branch from develop to feature/react17 December 30, 2020 02:35
@MikyungKim
Copy link
Contributor

Please update the subject and description of this PR more specifically.

@hong6316
Copy link
Contributor Author

Please update the subject and description of this PR more specifically.

@hong6316 hong6316 closed this Jan 11, 2021
@hong6316 hong6316 reopened this Jan 11, 2021
@hong6316 hong6316 changed the title PLAT-129601: Upgrade @pmmmwh/react-refresh-webpack-plugin module from… PLAT-129601: Upgrade react-refresh-webpack-plugin 0.3.3 -> 0.4.3 Jan 12, 2021
@hong6316 hong6316 changed the title PLAT-129601: Upgrade react-refresh-webpack-plugin 0.3.3 -> 0.4.3 PLAT-129601: Upgrade react-refresh-webpack-plugin 0.3.3 to 0.4.3 Jan 12, 2021
Copy link
Contributor Author

@hong6316 hong6316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikyungKim please review again

Copy link
Contributor

@MikyungKim MikyungKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine! :lgtm:

@MikyungKim MikyungKim merged commit 9f15f59 into feature/react17 Jan 13, 2021
@MikyungKim MikyungKim deleted the feature/PLAT-129601 branch January 13, 2021 04:28
SkylerBaek pushed a commit that referenced this pull request Feb 26, 2021
* 9037 Fix dotenv file loading order

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* Upgrade to React 17

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* Update dependencies

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* Revert react-refresh-webpack-plugin version

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* Replace inquirer with prompts

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* Replace inquirer with prompts in eject

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* 9374 Fix: use default modules option from preset-env

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* PLAT-129601: Upgrade react-refresh-webpack-plugin 0.3.3 to 0.4.3 (#231)

* PLAT-129601: Upgrade @pmmmwh/react-refresh-webpack-plugin module from 0.3.3 to 0.4.1

* Update CHANGELOG.md

* Update package-lock.json

* Update commands/eject.js (for fixing lint error)

* Update package.json 2

* 9964 Add TypeScript 4.x as peerDependency

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* PLAT-129600: Replace deprecated eslint-loader by eslint-webpack-plugin (#235)

* PLAT-129600: Replace eslint-loader to eslint-webpack-plugin

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* fix lint

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* PLAT-121645: Add support for new JSX Transform (#236)

* PLAT-121645: Add support for new JSX Transform

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* fix lint error

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* fix lint

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* Added a guard

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* update dependecies

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* Update @enact/moonstone-template dependency

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* added changelog

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

Co-authored-by: taeyoung.hong <35059065+hong6316@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants