Add UNAUTHENTICATED_USER = None note #5679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When removing authentication entirely you cannot import `django.contrib.auth.models.AnonymousUser` Closes encode#3494
xordoquy
approved these changes
Dec 19, 2017
There was a problem hiding this comment.
We could probably get around this by changing this line with:
'UNAUTHENTICATED_USER': 'django.contrib.auth.models.AnonymousUser' if 'django.contrib.auth' in settings.INSTALLED_APPS,
also should include a check on django.contrib.auth.apps.AuthConfig
|
@xordoquy Good point. It'd be good to see this bulletproofed. I don't see the ROI on testing it thoroughly myself though: it's been two years with no PR, so it can't be hurting too-many people. 🙂 To the future: Happy to see a PR improving this! |
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
When removing authentication entirely you cannot import `django.contrib.auth.models.AnonymousUser` Closes encode#3494
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing authentication entirely you cannot import
django.contrib.auth.models.AnonymousUserCloses #3494
Adds a note to the
UNAUTHENTICATED_USERsetting docs saying to set toNone.django.contrib.authis sufficiently beyond the core case that we can expect users to have discovered this (or do so with a quick search).