Add LimitOffsetPagination.get_count to allow method override #5846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpkilby
requested changes
Feb 23, 2018
rest_framework/pagination.py
Outdated
| def get_count(self, queryset): | ||
| """ | ||
| Determine an object count, supporting either querysets or regular lists. | ||
| """ |
There was a problem hiding this comment.
docstring spacing should be fixed
|
Yup I'm okay with this, pending @rpkilby's suggested changes. |
rpkilby
approved these changes
Mar 13, 2018
|
👍 |
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
…5846) * Add LimitOffsetPagination.get_count to allow method override * Format method docstring
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
pagination._get_countLimitOffsetPagination.get_countinstance methodLimitOffsetPagination.paginate_querysetI have a custom pagination class that subclasses
LimitOffsetPagination. When paginating a large queryset with an.order_by()clause, the combination of sorting can add a lot of overhead to the pagination calculation, which in turn slows down the entire response. Addingget_count()as an instance method gives developers the ability to override it's behavior if necessary. In my case, I will override the method to remove any ordering constraints from the queryset.