Skip to content

Fix RemoteUserAuthentication calling django authenticate with … #7158

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

puittenbroek
Copy link
Contributor

Fixes #7157

@kevin-brown
Copy link
Member

Looks like this was changed in https://code.djangoproject.com/ticket/25187 and we just missed it in #5295.

@kevin-brown kevin-brown added this to the 3.12 Release milestone Jan 27, 2020
@puittenbroek
Copy link
Contributor Author

Appears so :)

@tomchristie
Copy link
Member

I can only assume that approximately nobody is using this particular authentication class? 🤷‍♂️

But yup, let's get this (finally) in. And, thank you!

@tomchristie tomchristie added the Bug label Sep 3, 2021
@tomchristie tomchristie merged commit 655e803 into encode:master Sep 3, 2021
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RemoteUserAuthentication.authenticate calls django.contrib.auth.authenticate without request argument
4 participants