Make autogenerated read only fields to be able to be nullable #8536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchristie
approved these changes
Jun 28, 2022
There was a problem hiding this comment.
Okay, yup.
I’ve pushed back on this in the past because “read_only” seemed inconsistent with “allow_null” from a behavioural perspective.
I’d say this, because “allow_null” is strictly something that we use to validate input.
However we’re not guarding against that case as we are for some others… https://github.com/encode/django-rest-framework/blob/master/rest_framework/fields.py#L336 …so if this is beneficial for introspection purposes, then okay. Let’s allow it.
sigvef
pushed a commit
to sigvef/django-rest-framework
that referenced
this pull request
Dec 3, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move null attr check before return for read-only fields. While as of now it doesn't break anything, it leads to incorrect API schema generation when using drf-spectacular(tfranzel/drf-spectacular#383) or drf-yasg(axnsan12/drf-yasg#310).