Skip to content

Update docstring #9340

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

jthevos
Copy link
Contributor

@jthevos jthevos commented Mar 22, 2024

This function no longer uses generators. The docstring should reflect that. Note: because there good comments in the function body, we don't need to repeat them in the docstring.

Note: Before submitting this pull request, please review our contributing guidelines.

Description

Please describe your pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. When linking to an issue, please use refs #... in the description of the pull request.

This function no longer uses generators. The docstring
should reflect that. Note: because there good comments
in the function body, we don't need to repeat them in
the docstring.
@jthevos jthevos force-pushed the update_docstring_to_reflect_implementation branch from 37ef03e to ffc2ed8 Compare March 22, 2024 19:31
@tomchristie tomchristie merged commit f4194c4 into encode:master Mar 22, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants