Skip to content

Drop HTML line breaks on long headers in browsable API #9438

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
Apr 28, 2025
Merged

Drop HTML line breaks on long headers in browsable API #9438

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bf9212d
Drop HTML line breaks on long headers
tomchristie Jun 14, 2024
2445421
Merge branch 'master' into drop-break-long-headers
auvipy Jun 15, 2024
b58adec
Merge branch 'master' into drop-break-long-headers
browniebroke Apr 27, 2025
850fa8a
Remove related test
browniebroke Apr 27, 2025
beb2cf7
Fix flake8
browniebroke Apr 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rest_framework/templates/rest_framework/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ <h1>{{ name }}</h1>

<div class="response-info" aria-label="{% trans "response info" %}">
<pre class="prettyprint"><span class="meta nocode"><b>HTTP {{ response.status_code }} {{ response.status_text }}</b>{% for key, val in response_headers|items %}
<b>{{ key }}:</b> <span class="lit">{{ val|break_long_headers|urlize }}</span>{% endfor %}
<b>{{ key }}:</b> <span class="lit">{{ val|urlize }}</span>{% endfor %}

</span>{{ content|urlize }}</pre>
</div>
Expand Down
10 changes: 0 additions & 10 deletions rest_framework/templatetags/rest_framework.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,13 +314,3 @@ def smart_urlquote_wrapper(matched_url):
except ValueError:
return None


@register.filter
def break_long_headers(header):
"""
Breaks headers longer than 160 characters (~page length)
when possible (are comma separated)
"""
if len(header) > 160 and ',' in header:
header = mark_safe('<br> ' + ', <br>'.join(escape(header).split(',')))
return header
Loading