-
-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Make raise_for_status
chainable
#2776
Conversation
a2f8dbe
to
00c6795
Compare
raise_for_status
chainableraise_for_status
chainable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It's a small change, but the experience will be much better.
Okay great, so...
|
I think this usage should be mentioned in the docstring and prose documentation. |
Really nice DX improvement here, I see myself using this a lot! |
document updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Some minor suggestions...
(Other could also be considered)
Co-authored-by: Tom Christie <tom@tomchristie.com>
Co-authored-by: Tom Christie <tom@tomchristie.com>
Co-authored-by: Tom Christie <tom@tomchristie.com>
is there any ETA on next release? |
If you're up for helping drive a release pull request, then we could fix up a minor point release whenever really. |
Can we include encode/httpcore#745 in the next httpx release? First, we should release httpcore with that pull request and then release httpx |
Summary
make it possible to write code like
r = httpx.get('...').raise_for_status().json()
Refs #2775
Checklist