Review URL percent escaping sets, from whatwg. #3371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchristie
added
the
user-experience
Fix incorrect test name.
This was referenced Oct 28, 2024
Merged
Closed
Merged
elupus
reviewed
Dec 23, 2024
| assert new.username == "tom@example.org" | ||
| assert new.password == "abc123@ %" | ||
| assert new.userinfo == b"tom%40example.org:abc123%40%20%25" | ||
| assert new.userinfo == b"tom%40example.org:abc123%40%20%" |
There was a problem hiding this comment.
This looks weird. I could be wrong. But should the userinfo field contain partial escapes? The trialing % sign change here seem odd.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review and update which characters should be percent escaped when parsing & normalising URLs.
Based on the URL living standard... https://url.spec.whatwg.org/
Prompted by #3360