Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Take weak ETags in consideration on StaticFiles #2334

Merged
merged 9 commits into from
Dec 16, 2023
Merged

Take weak ETags in consideration on StaticFiles #2334

merged 9 commits into from
Dec 16, 2023

Conversation

neolooong
Copy link
Contributor

Summary

fix #2298.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@Kludex Kludex requested a review from karpetrosyan December 1, 2023 16:35
@karpetrosyan karpetrosyan added the bug Something isn't working label Dec 4, 2023
@Kludex Kludex mentioned this pull request Dec 10, 2023
Merged
3 tasks
Kludex
Kludex reviewed Dec 16, 2023
View reviewed changes
starlette/staticfiles.py Outdated Show resolved Hide resolved
@Kludex Kludex changed the title Fix staticfile etag Take weak ETags in consideration on StaticFiles Dec 16, 2023
@Kludex Kludex merged commit 3c8ab8e into encode:master Dec 16, 2023
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Kludex Kludex Kludex left review comments

@karpetrosyan karpetrosyan karpetrosyan approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strong and weak etags for StaticFiles
3 participants
@neolooong @Kludex @karpetrosyan