Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix nav override for newer version of Mkdocs Material #2444

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Fix nav override for newer version of Mkdocs Material #2444

merged 1 commit into from
Jan 26, 2024

Conversation

frankie567
Copy link
Member

Follow-up to #2439

Same symptoms and same solution as in encode/uvicorn#2233:

Following #2229, I've investigated why the navigation bar was hidden in newer version of Mkdocs Material. The partials/nav.html have slightly changed, so we needed to update our own override.

Now it displays correctly!

@frankie567 frankie567 requested a review from Kludex January 26, 2024 12:30
@Kludex Kludex enabled auto-merge (squash) January 26, 2024 12:32
@Kludex Kludex merged commit 4355e6b into master Jan 26, 2024
5 checks passed
@Kludex Kludex deleted the docs/fix-mkdocs-material branch January 26, 2024 12:32
nixroxursox pushed a commit to nixroxursox/starlette that referenced this pull request Mar 18, 2024
@frankie567
Fix nav override for newer version of Mkdocs Material (encode#2444)
7a14823
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankie567 @Kludex