Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Local static variables with same name not diffed properly #85

Closed
LagoLunatic opened this issue Jul 22, 2024 · 1 comment
Closed

Local static variables with same name not diffed properly #85

LagoLunatic opened this issue Jul 22, 2024 · 1 comment

Comments

@LagoLunatic
Copy link
Contributor

The new feature added in beta.1 to detect that name$1234 and name$4321 are the same variable works well in most cases, the only issue is that in the edge case when a single section has multiple different variables with the same name but different numbers, objdiff seems to match the pairs up together incorrectly.

Example from d_a_player_main's .rodata section:
image

ripple_scale$8193 and ripple_scale$2352 are the same variable and should match, but objdiff shows 100% on the left and 75% on the right.
ripple_scale$21928 and ripple_scale$4891 are the same variable and should match, but objdiff shows 75% on the left and no percentage on the right.
Same with offset$39104/offset$8598 and offset$39108/offset$8599.
All should show 100% because the bytes do match in the data view.

encounter added a commit that referenced this issue Aug 11, 2024
This re-implements the older algorithm
used for data and BSS section match
percentages. We perform both and
choose the highest match percent
between the two options.

Resolves #84, #85
@encounter
Copy link
Owner

Fixed in e1ccee1

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants