You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The new feature added in beta.1 to detect that name$1234 and name$4321 are the same variable works well in most cases, the only issue is that in the edge case when a single section has multiple different variables with the same name but different numbers, objdiff seems to match the pairs up together incorrectly.
Example from d_a_player_main's .rodata section:
ripple_scale$8193 and ripple_scale$2352 are the same variable and should match, but objdiff shows 100% on the left and 75% on the right.
ripple_scale$21928 and ripple_scale$4891 are the same variable and should match, but objdiff shows 75% on the left and no percentage on the right.
Same with offset$39104/offset$8598 and offset$39108/offset$8599.
All should show 100% because the bytes do match in the data view.
The text was updated successfully, but these errors were encountered:
This re-implements the older algorithm
used for data and BSS section match
percentages. We perform both and
choose the highest match percent
between the two options.
Resolves#84, #85
The new feature added in beta.1 to detect that
name$1234
andname$4321
are the same variable works well in most cases, the only issue is that in the edge case when a single section has multiple different variables with the same name but different numbers, objdiff seems to match the pairs up together incorrectly.Example from d_a_player_main's .rodata section:
![image](https://private-user-images.githubusercontent.com/19174152/351041229-17cb20f3-fe28-482e-a644-bc7505c42175.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MzM1NzYsIm5iZiI6MTczOTQzMzI3NiwicGF0aCI6Ii8xOTE3NDE1Mi8zNTEwNDEyMjktMTdjYjIwZjMtZmUyOC00ODJlLWE2NDQtYmM3NTA1YzQyMTc1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDA3NTQzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA2ZDdkMTM5ZTg1ZjdjYTM0Yjc1NDlmZWU0NWVhYThiMjljZDgxNTNhZDYwYjI0OTEyYWQ2ZjkwOGI0YjJjMmMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.evonpWNYS4mC9SCSuZQoOcdDpUKas5QJE8GjFc1eTPc)
ripple_scale$8193 and ripple_scale$2352 are the same variable and should match, but objdiff shows 100% on the left and 75% on the right.
ripple_scale$21928 and ripple_scale$4891 are the same variable and should match, but objdiff shows 75% on the left and no percentage on the right.
Same with offset$39104/offset$8598 and offset$39108/offset$8599.
All should show 100% because the bytes do match in the data view.
The text was updated successfully, but these errors were encountered: