Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[new-product] Eclipse Jetty #4122

Merged
merged 7 commits into from
Dec 26, 2023
Merged

Conversation

kmoens
Copy link
Contributor

@kmoens kmoens commented Nov 20, 2023

No description provided.

Copy link

welcome bot commented Nov 20, 2023

Thank you for opening this pull request 👍. If you are not familiar with the project, please check out our Contributing Guidelines and our Guiding Principles. Also take a look at our Hacking Guide if you intend to work on site internals.

@marcwrobel marcwrobel changed the title Eclipse Jetty [new-product] Eclipse Jetty Nov 20, 2023
@marcwrobel marcwrobel added the new-product This PR adds a new product to the website. label Nov 20, 2023
Copy link
Member

@marcwrobel marcwrobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution @kmoens, I left you a few questions and suggestions.

products/jetty.md Outdated Show resolved Hide resolved
products/jetty.md Outdated Show resolved Hide resolved
products/jetty.md Outdated Show resolved Hide resolved
products/jetty.md Outdated Show resolved Hide resolved
products/jetty.md Outdated Show resolved Hide resolved
products/jetty.md Outdated Show resolved Hide resolved
products/jetty.md Outdated Show resolved Hide resolved
products/jetty.md Outdated Show resolved Hide resolved
@marcwrobel marcwrobel self-requested a review November 29, 2023 21:00
Copy link
Member

@marcwrobel marcwrobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the updates @kmoens, I have added some more comments and suggestions.

products/eclipse-jetty.md Show resolved Hide resolved
products/eclipse-jetty.md Outdated Show resolved Hide resolved
products/eclipse-jetty.md Outdated Show resolved Hide resolved
products/eclipse-jetty.md Outdated Show resolved Hide resolved
products/eclipse-jetty.md Show resolved Hide resolved
@marcwrobel marcwrobel self-requested a review December 26, 2023 09:37
Copy link
Member

@marcwrobel marcwrobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the page according to what was said in #4122 (comment). Also made a few other changes (tags, supported Servlet / JSP...).

LGTM now, will merge. Thanks a lot @kmoens and sorry it tooks so long for me to review your changes.

@marcwrobel marcwrobel merged commit bb4d42b into endoflife-date:master Dec 26, 2023
5 checks passed
Copy link

welcome bot commented Dec 26, 2023

Thank you and congratulations for your first contribution! endoflife.date is a community wiki, and we're always looking for more contributions 🥇 💯 🎉.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
new-product This PR adds a new product to the website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants