Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make the releaseDateColumn field be true by default #6678

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

waldyrious
Copy link
Contributor

@waldyrious waldyrious commented Jan 30, 2025

Make the releaseDateColumn field be true by default

(Includes a commit removing the now redundant releaseDateColumn: true from all products/*.md files)

Fixes #6669

@waldyrious waldyrious force-pushed the releaseDateColumn-default-true branch from 651b760 to 36a30c7 Compare January 30, 2025 22:53
@waldyrious waldyrious force-pushed the releaseDateColumn-default-true branch from 36a30c7 to 2997a4f Compare January 30, 2025 23:02
@waldyrious
Copy link
Contributor Author

waldyrious commented Jan 30, 2025

CI was failing until I explicitly added releaseDateColumn: false to ckeditor.md, readynas.md, robo.md and steamos.md in 2997a4f, as those seemed to be relying on the default value of the field being false.

However, I couldn't figure out what exactly are the triggering conditions, common to these files, leading to the failures. I'd like to add a note to CONTRIBUTING.md to explain in which cases releaseDateColumn needs to be set to false — something similar to:

# End Of Active Support date (mandatory if eoasColumn is true, else MUST NOT be set).

or

# End Of Extended/commercial Support date (optional if eoesColumn is true, else SHOULD NOT be set).

Any insights as to what might have been the cause(s) of the errors?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make releaseDateColumn true by default
1 participant