feat(eslint-plugin): accept the syntax currently allowed at Agoric #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
force-pushed
the
mfig-jessie-eslint
branch
from
cb2c08c to
43a0b96
Compare
This was referenced Aug 10, 2021
Merged
dckc
approved these changes
Aug 10, 2021
| create(context) { | ||
| return { | ||
| AwaitExpression: node => { | ||
| // As a hint to future readers, I used the following ASTExplorer |
There was a problem hiding this comment.
thanks for leaving breadcrumbs :)
| selector: `ArrowFunctionExpression[async=true]`, | ||
| message: `async functions are ${nono}`, | ||
| selector: `FunctionExpression[generator=true]`, | ||
| message: `generators are ${nono}`, |
There was a problem hiding this comment.
Do we have library function alternatives to generators?
There was a problem hiding this comment.
In progress. It takes some explanation, though, so I'm not sure yet what to put in the linting failure.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most major addition to the
@jessie.js/eslint-pluginis to enableasyncfunctions and properly lint the use ofawait. The rules allow for:awaitexpression statements at the top level of anasyncfunction (either the topmost block or the only expression, if an arrow function).SOMETHING = await somethingElse;statements at the function's topmost block or expression.await.The other changes should be fairly self-explanatory. They were determined by examining the Jessica grammars for Jessie, driven by @dckc's Agoric/documentation#540.